Pull Request Guidelines

# Ensure you're on your feature branch
git checkout feature/your-feature-name

# Push to your fork
git push origin feature/your-feature-name

type(scope): brief description

✅ Good titles:
feat(auth): add two-factor authentication
fix(secure): prevent XSS in password notes
docs(setup): update Node.js version requirements
refactor(api): simplify error handling logic

❌ Bad titles:
Update code
Fix bug
Changes
New feature

## Summary
Brief overview of what this PR does (1-2 sentences).

## Changes
- List of specific changes made
- Each change on its own line
- Be specific and detailed

## Motivation
Why are these changes needed? What problem do they solve?

## Testing
How were these changes tested?
- [ ] Tested locally
- [ ] Type checking passes
- [ ] Linting passes
- [ ] Build succeeds
- [ ] Manual testing completed

## Screenshots (if applicable)
[Add screenshots for UI changes]

## Related Issues
Closes #123
Related to #456

## Additional Notes
Any other context or information reviewers should know.

## Summary
<!-- Brief overview of the changes -->

## Type of Change
- [ ] Bug fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation update
- [ ] Code refactoring
- [ ] Performance improvement
- [ ] Other (please describe):

## Changes Made
<!-- Detailed list of changes -->
- 
- 
- 

## Motivation and Context
<!-- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
<!-- Describe how you tested your changes -->
- [ ] Type checking (`pnpm check-types`)
- [ ] Linting (`pnpm lint`)
- [ ] Build succeeds (`pnpm build`)
- [ ] Manual testing in browser
- [ ] Tested edge cases
- [ ] Tested error scenarios

## Screenshots (if applicable)
<!-- Add screenshots for UI changes -->

## Checklist
- [ ] My code follows the code style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings or errors
- [ ] I have tested my changes locally
- [ ] All automated checks pass

## Related Issues
<!-- Link related issues -->
Closes #
Related to #

## Additional Notes
<!-- Any other information that reviewers should know -->

# ✅ Good - focused commits
git commit -m "feat(auth): add login form component"
git commit -m "feat(auth): implement login API endpoint"
git commit -m "feat(auth): add session management"

# ❌ Bad - everything in one commit
git commit -m "add authentication"

### Before
![Before](./before.png)

### After
![After](./after.png)

Closes #123        # Closes the issue
Fixes #456         # Fixes the issue
Resolves #789      # Resolves the issue
Related to #101    # Links without closing

# Make requested changes
git add .
git commit -m "fix: address review feedback"
git push origin feature/your-feature-name

Good point! I've updated the code to:
- Extract the validation logic into a separate function
- Add error handling for edge cases
- Include JSDoc comments

Let me know if this addresses your concern.

# Update your branch with latest main
git checkout main
git pull upstream main

# Rebase your feature branch
git checkout feature/your-feature-name
git rebase main

# Resolve conflicts, then:
git add .
git rebase --continue

# Force push (be careful!)
git push origin feature/your-feature-name --force

## [WIP] Feature Name

⚠️ **This PR is a work in progress**

I'm working on implementing X feature and would like early feedback on the approach.

### TODO
- [ ] Complete implementation
- [ ] Add tests
- [ ] Update documentation

### Questions
- Is this the right approach?
- Should I split this into multiple PRs?

## fix(auth): prevent session timeout during active use

### Summary
Fixes an issue where users were being logged out even while actively using the application.

### Changes
- Update session refresh logic to extend timeout on user activity
- Add activity tracking for mouse and keyboard events
- Debounce activity events to reduce API calls

### Motivation
Users reported being unexpectedly logged out while filling out forms. The session timeout was not being extended during active use.

### Testing
- [x] Tested locally with 5-minute timeout
- [x] Verified session extends on user activity
- [x] Confirmed no session extension when idle
- [x] Type checking passes
- [x] Linting passes
- [x] Build succeeds

### Related Issues
Fixes #234

## feat(secure): add password strength indicator

### Summary
Adds a visual password strength indicator to the password creation form.

### Changes
- Create `PasswordStrength` component
- Implement strength calculation algorithm
- Add visual feedback with colors and text
- Include strength requirements checklist
- Add tests for strength calculation

### Motivation
Users requested better guidance when creating passwords. This helps them create strong passwords and reduces weak password attempts.

### Screenshots
![Password Strength](./strength-indicator.png)

### Testing
- [x] Tested with various password strengths
- [x] Verified color coding (red/yellow/green)
- [x] Tested accessibility with screen reader
- [x] All checks pass

### Related Issues
Closes #456