/sdd-verify

/sdd-verify [change-name]

# Run test suite
$ npm test
✓ 47 tests passed
✗ 2 tests failed

# Run build
$ npm run build
✓ Build succeeded (2.3s)

# Check coverage
$ npm test -- --coverage
✓ Coverage: 87% (threshold: 80%)

/sdd-verify

## Verifying change: add-dark-mode

### Loading Artifacts
✓ Proposal loaded
✓ Specs loaded (2 files, 11 scenarios)
✓ Design loaded
✓ Tasks loaded (9 tasks)

---

## Validation Checks

### Completeness Check ✓
- ✓ All 9 tasks marked complete
- ✓ All files mentioned in tasks exist
- ⚠️  1 TODO comment found in ThemeToggle.tsx:45

### Correctness Check ✓
- ✓ 11/11 spec scenarios addressed in implementation
- ✓ All MUST requirements implemented
- ✓ All SHOULD requirements implemented
- ⊘ MAY requirement (custom themes) skipped per proposal

### Coherence Check ✓
- ✓ CSS custom properties approach followed
- ✓ React Context pattern implemented as designed
- ✓ localStorage schema matches design
- ✓ Existing component conventions maintained

### Quality Check ✓
Running tests...

✓ 52 tests passed (all previous + 5 new theme tests)
✗ 0 tests failed

Running build...

✓ Build succeeded (2.4s)
✓ No TypeScript errors
✓ Bundle size: +3.2kb (acceptable)

Checking coverage...

✓ Coverage: 89% (threshold: 80%)
✓ New files covered: ThemeContext 100%, ThemeToggle 95%

---

## Spec Compliance Matrix

| ID | Requirement | Status | Evidence |
|----|-------------|--------|----------|
| UI-1 | System SHALL support light and dark themes | ✓ PASS | CSS variables in globals.css:15-42 |
| UI-2 | User SHALL be able to toggle between themes | ✓ PASS | ThemeToggle component + test passing |
| UI-3 | User preference SHALL persist across sessions | ✓ PASS | localStorage integration:28-30, test passing |
| UI-4 | System SHOULD detect initial preference | ✓ PASS | matchMedia in ThemeContext:18-22 |
| UI-5 | Theme SHOULD apply without page reload | ✓ PASS | React Context + CSS classes, test passing |
| UI-6 | System SHOULD prevent theme flash on load | ✓ PASS | Inline script in Layout |
| UI-7 | Toggle MAY show current theme state | ✓ PASS | Icon changes in ThemeToggle:15-20 |

**Summary**: 7/7 scenarios PASS, 0 FAIL, 0 SKIP

---

## Issues Found

### CRITICAL
None ✓

### WARNING
1. TODO comment in src/components/ThemeToggle.tsx:45
   ```typescript
   // TODO: Add keyboard shortcut for theme toggle

### Verification with Failures

```markdown
## Verifying change: add-csv-export

### Quality Check ❌

Running tests...

✓ 50 tests passed
✗ 2 tests failed

**Failed Tests**:

1. `CSV Export › should handle special characters`

2. `CSV Export › should include UTF-8 BOM for Excel`

Running build...

✓ Build succeeded

---

## Spec Compliance Matrix

| ID | Requirement | Status | Evidence |
|----|-------------|--------|----------|
| API-1 | SHALL export data in CSV format | ✓ PASS | Endpoint implemented, basic test passing |
| API-2 | SHALL support UTF-8 encoding with BOM | ✗ FAIL | Test failing: no BOM added |
| API-3 | SHALL include column headers | ✓ PASS | Headers present in output |
| API-4 | SHOULD handle special characters | ✗ FAIL | Test failing: quotes not applied |
| API-5 | MAY support custom date formats | ⊘ SKIP | Not implemented (optional) |

**Summary**: 2/5 scenarios PASS, 2 FAIL, 1 SKIP

---

## Issues Found

### CRITICAL

1. SHOULD requirement not met: Special character handling
   - **Spec**: API-4 "SHOULD handle special characters (quotes, commas, newlines)"
   - **Test**: Failing - quotes not applied to fields with commas
   - **Fix**: Update CsvSerializer to quote fields per RFC 4180

2. MUST requirement not met: UTF-8 BOM
   - **Spec**: API-2 "SHALL support UTF-8 encoding with BOM for Excel"
   - **Test**: Failing - BOM not present
   - **Fix**: Add \uFEFF at start of CSV string

### WARNING
None

### SUGGESTION
None

---

## Verification Report

**Status**: ❌ FAIL

### Summary
- 2 requirements not met
- 2 tests failing
- Build successful
- 2 critical issues blocking archive

### Recommendation
**NOT ready to archive** - Fix critical issues first.

1. Add UTF-8 BOM to CSV output
2. Quote CSV fields containing special characters
3. Re-run verification after fixes

### Artifacts
- openspec/changes/add-csv-export/verification-report.md

---

❌ Verification failed. Address critical issues and run `/sdd-verify` again.

schema: spec-driven

# Test execution
test_command: npm test
build_command: npm run build

# Quality gates
coverage_threshold: 80

rules:
  verify:
    - Run tests if test infrastructure exists
    - Compare implementation against every spec scenario
    - Check that all MUST/SHALL requirements are met
    - Report TODO comments as warnings
    - Run build to catch compilation errors

✓ The system SHALL persist user preferences
✓ The API MUST return 200 on success
✗ The service SHALL validate input before processing  ← CRITICAL if missing

✓ The UI SHOULD show loading state
⚠️  The API SHOULD rate-limit requests  ← WARNING if missing

⊘ The system MAY support custom themes  ← OK to skip

# Verification Report: {change-name}

Date: 2024-03-04
Status: PASS | FAIL | PASS WITH WARNINGS

## Executive Summary
{2-3 sentence overview}

## Validation Results

### Completeness
- Tasks: X/Y complete
- Files: All present / N missing
- TODOs: N found

### Correctness
- Scenarios: X/Y passing
- Requirements: MUST (X/Y), SHOULD (X/Y), MAY (X/Y)

### Coherence
- Design decisions: X/Y followed
- Patterns: Consistent / Deviations found

### Quality
- Tests: X passing, Y failing
- Build: Success / Failed
- Coverage: X% (threshold: Y%)

## Spec Compliance Matrix
{Table mapping requirements to implementation}

## Issues by Severity

### CRITICAL
{Blocking issues}

### WARNING
{Non-blocking issues}

### SUGGESTION
{Improvements}

## Recommendation
Ready to archive | Needs work
{Specific next steps}