Introduction
Thank you for considering contributing to Viaduct! We’re glad you’re here. Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue, assessing changes, and helping you finalize your pull requests. Viaduct is an open source project, and we love to receive contributions from our community — you! There are many ways to contribute, from writing tutorials or blog posts, improving the documentation, submitting bug reports and feature requests or writing code which can be incorporated into Viaduct itself.Please use the discussion board for support questions.
Ground Rules
- Adhere to our code of conduct
- Changes must be adequately documented and tested
- Pull requests must use our PR template (excluding screenshot section)
- We welcome contributions ranging from tutorials to documentation improvements to bug reports and feature requests. We also welcome contributions to Viaduct itself
- Major changes should first be discussed with an Issue. Be transparent and get community feedback
- Pull requests should be as small as possible. Make one change at a time
- At the same time, “gardening” is welcome. No need to make a separate pull request if you (eg) fix an unrelated typo or clear up a variable name along the way
- By contributing to this repository, you agree that your contributions will be licensed under the Apache License, Version 2.0
Your First Contribution
Unsure where to begin contributing to Viaduct? You can start by looking through these beginner and help-wanted issues:- Beginner issues - issues which should only require a few lines of code and a test or two
- Help wanted issues - issues which are a bit more involved than beginner issues
- Both issue lists are sorted by total number of comments. While not perfect, the number of comments is a reasonable proxy for the impact a given change will have
Getting Started
- Create your own fork of the code
- Do the changes in your fork
- Ensure your change includes tests and that all tests pass
- If you like the change and think the project could use it:
- Be sure you have followed the code style for the project
- Note the Viaduct Code of Conduct
- Open a pull request against the main Viaduct repository
How to Report a Bug
Security Disclosures
Any security issues should be submitted directly to the Airbnb bug bounty program. In order to determine whether you are dealing with a security issue, ask yourself these two questions:- Can I access something that’s not mine, or something I shouldn’t have access to?
- Can I disable something for other people?
Filing an Issue
When filing an issue, you will be asked to answer the following questions:- Who is the bug affecting?
- What is affected by this bug?
- When does this occur?
- Where on the platform does it happen?
- How do we replicate the issue?
- What is the expected behavior?
How to Suggest a Feature or Enhancement
Start a discussion on GitHub which describes the feature you would like to see, why you need it, and how it should work. The community will discuss your idea there and reach consensus on a way forward.Code Review Process
The core team looks at Pull Requests on a regular basis in a weekly triage meeting. After feedback has been given we expect responses within two weeks. After two weeks we may close the pull request if it isn’t showing any activity.Branch Rules
Pushes tomain are not allowed. All changes must come through pull requests. Release tag creation is also restricted to repository maintainers.
Community
If you have questions about the contribution process or want to discuss specific issues, please start a discussion on GitHub.Building Locally
Plugins
To build and publish all Viaduct artifacts to your local Maven repository:mavenLocal() to your repositories list. The version of the artifacts will be 0.0.0-SNAPSHOT.
Binary Compatibility Validation (BCV)
Viaduct uses the Kotlin Binary Compatibility Validator Gradle plugin (org.jetbrains.kotlinx.binary-compatibility-validator) to track and enforce the public binary API of selected modules.
BCV works by generating and checking .api signature files for modules that apply the BCV convention plugin id("conventions.bcv-api"), like :tenant:api and :service:api.
Developers should amend those .api files when making intentional changes by executing:
Tests
Run tests with:Demo Apps
To build and test demo apps:Release Process
Releases are listed on the releases page.Who is Responsible for a Release?
Releases are performed by maintainers according to the RELEASE-RUNBOOK.md. The release process requires permissions only held by maintainers. If you are an external contributor and would like to help with a release, please reach out to the core team via a GitHub discussion.Versioning
Viaduct adheres to Semantic Versioning.Cadence
Until we release Viaduct 1.0, we are releasing a new minor version on a roughly weekly basis.Release Artifacts
Release artifacts are published to the Gradle Plugin Portal and Maven Central.Maven Central
Runtime libraries are published to Maven Central. Artifacts are grouped under thecom.airbnb.viaduct group ID. The Viaduct BOM is the recommended way to manage versions of Viaduct dependencies.