Best Practices

// Old: ES5 with var and function
var fetchData = function(url) {
  return fetch(url).then(function(r) { return r.json(); });
};

// Modern: ES6+ with const and arrow functions
const fetchData = async (url) => {
  const response = await fetch(url);
  return response.json();
};

# Check out the PR branch
gh pr checkout <pr-number>

# Run unit tests
npm test
# or
pytest

# Check for test failures
# ✅ All tests pass → Good!
# ❌ Tests fail → Investigate changes

# Run integration test suite
npm run test:integration

# Check API endpoints, database interactions, etc.

# Run E2E tests (Cypress, Playwright, etc.)
npm run test:e2e

# Verify critical user flows

# Start dev server
npm run dev

# Test core functionality:
# 1. Navigate to key pages
# 2. Try main user actions
# 3. Verify data displays correctly

// Problem: async added but no await
async function getData() {
  return fetch(url).then(r => r.json()); // Should use await!
}

// Correct:
async function getData() {
  const response = await fetch(url);
  return response.json();
}

// Before: Synchronous
function getConfig() {
  return config;
}

// After: Asynchronous (breaking change!)
async function getConfig() {
  return config; // Now returns Promise<config>, not config!
}

// Callers must now await:
const cfg = await getConfig(); // Required change!

Week 1: Modernize utils/ folder
Week 2: Modernize components/ folder
Week 3: Modernize services/ folder

# Run Dependify on specific subdirectory
# (Feature not yet implemented, but you can manually select files after PR creation)

# Alternative: Use PR review to only merge specific files
# 1. Create full Dependify PR
# 2. Manually cherry-pick files to merge
# 3. Close original PR, merge cherry-picked changes

Phase 1: var → const/let only
Phase 2: Promise chains → async/await
Phase 3: Class components → functional components

Priority 1: Low-risk utility files
Priority 2: Medium-risk UI components
Priority 3: High-risk business logic

// package.json
{
  "browserslist": [
    "> 1%",
    "last 2 versions",
    "not dead"
  ]
}

node --version
# Ensure it supports modern syntax

npm list react
# Ensure version >= 16.8.0

npm install react@latest react-dom@latest

python --version
# Ensure Python 3.6+

# Before
npm run lint # 150 warnings

# After Dependify
npm run lint # 50 warnings (improvement!)